[infinispan-issues] [JBoss JIRA] Commented: (ISPN-889) Remove JBoss Common Core dependency

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577470#comment-12577470 ] 

Galder Zamarreño commented on ISPN-889:
---------------------------------------

An good rule suggested by Pete:

"My rule for library/framework development has always been that you should use at least 20% of a dependencies functionality if you want to add it as a dependency (rather than just copy the source to your code base). If you are using >50% you should add it, no question, and in between you have to make a decision case-by-case."

> Remove JBoss Common Core dependency
> -----------------------------------
>
>                 Key: ISPN-889
>                 URL: https://issues.jboss.org/browse/ISPN-889
>             Project: Infinispan
>          Issue Type: Thirdparty Change
>            Reporter: Galder Zamarreño
>            Assignee: Galder Zamarreño
>             Fix For: 4.2.1.Final, 5.0.0.BETA1
>
>
> Looking at Infinispan's dependencies, core seems to depend on JBoss Common Core simply to take advantage of org.jboss.util.StringPropertyReplacer.
> Test code also depends for org.jboss.util.naming.NonSerializableFactory.
> What about we make our own org.jboss.util.StringPropertyReplacer and remove JBoss Common Core from being a main dependency? We could still keep it as a test dependency for org.jboss.util.naming.NonSerializableFactory.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira