[infinispan-issues] [JBoss JIRA] Commented: (ISPN-1267) IsMarshallableInterceptor causes unnecessary marshalling in remote access mode

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616419#comment-12616419 ] 

Galder Zamarreño commented on ISPN-1267:
----------------------------------------

Slightly intrigued about the expensiveness of GJM.isMarshallable() cos even though it could be improved (it could skip all basic types, including byte[]), once it's tried to marshall a byte[], the type and the result of isMarshallable is cached in a ConcurrentWeakKeyHashMap. So, the rest should be straight map lookups.

It's true too that storeAsBinary does not make sense with any servers could data is already stored as byte[] or String in the case of Memcached keys. That can be forced on HRS startup.

I'm checking the last jprofiler snapshots available to try to understand this better.

Thanks Michal!

> IsMarshallableInterceptor causes unnecessary marshalling in remote access mode
> ------------------------------------------------------------------------------
>
>                 Key: ISPN-1267
>                 URL: https://issues.jboss.org/browse/ISPN-1267
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Marshalling
>    Affects Versions: 5.0.0.CR8
>            Reporter: Michal Linhard
>            Assignee: Manik Surtani
>             Fix For: 5.0.0.FINAL
>
>
> this is because by default GenericJBossMarshaller is used and
> GenericJBossMarshaller.isMarshallable implementation marshalls objects to find whether they are marshallable. 
> this proves to be a very significant performance bottleneck, see details in JBPAPP-6865
> in remote access storeAsBinary shouldn't have any performance impact, because the values that are received on serverside are already byte arrays.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira