[infinispan-issues] [JBoss JIRA] Commented: (ISPN-1162) Duplicate command ID check should include user defined ones too

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609237#comment-12609237 ] 

Galder Zamarreño commented on ISPN-1162:
----------------------------------------

We don't currently have any way to check for duplicate command ids in the infinispan-core, we simply have a unit test that verifies that. So, rather than trying to build this, I've gone for the approach I suggested in the forum thread, where infinispan-core commands and external commands are indexed differently in the stream.

So, by indexing infinispan-core modules with 0, and module commands with 1, duplicates can be discovered more easily. The unit test we have discovers duplicate commands in the core/ module, and the infrastructure in ModuleProperties checks for dups for the rest.

It might not be the prettiest of solutions. A global check for duplicate ids might be the correct solution, but I think it's the most pragmatic one and the one requiring the least amount of changes.

Also, with this solution, external commands can be indexed from 1 without having any effect the internal commands.

> Duplicate command ID check should include user defined ones too
> ---------------------------------------------------------------
>
>                 Key: ISPN-1162
>                 URL: https://issues.jboss.org/browse/ISPN-1162
>             Project: Infinispan
>          Issue Type: Bug
>    Affects Versions: 5.0.0.CR4
>            Reporter: Galder Zamarreño
>            Assignee: Galder Zamarreño
>             Fix For: 5.0.0.CR7
>
>
> Infinispan does not take into account user-defined command Ids when checking for duplicate ids.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira