[infinispan-issues] [JBoss JIRA] Commented: (ISPN-936) putAll suboptimal and possibly wrong

[Manik Surtani (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585880#comment-12585880 ] 

Manik Surtani commented on ISPN-936:
------------------------------------

This isn't *incorrect* since the DistLockingInterceptor (see commitEntry()) ensures than entries are either transformed for L1 or not stored at all.  PutAllTest verifies this.

However, I agree that it is suboptimal.  Will look at fixing.

> putAll suboptimal and possibly wrong
> ------------------------------------
>
>                 Key: ISPN-936
>                 URL: https://issues.jboss.org/browse/ISPN-936
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Distributed Cache
>    Affects Versions: 4.2.0.Final
>            Reporter: Mircea Markus
>            Assignee: Manik Surtani
>             Fix For: 4.2.1.FINAL, 5.0.0.Final
>
>
> DistributionManager.visitPutMapCommand broadcasts ALL the map entries to ALL the nodes to which keys are mapped.
> E.g. if Map={k1=v1, k2=v2} and k1 maps to node A, k2 maps to node B then both A and B would receive {k1=v1, k2=v2}. 
> The way it should be is A receives {k1=v1} and B receives {k2=v2}. 
> This is suboptimal and error prone as, by the look of code, both nodes would store ALL the data in the data container. 
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira