[infinispan-issues] [JBoss JIRA] Commented: (ISPN-1008) Conditional replace/remove not returning previous value in Java Hot Rod client

[Mircea Markus (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601444#comment-12601444 ] 

Mircea Markus commented on ISPN-1008:
-------------------------------------

I like more the current approach, which ignores last value and returns a boolean. More close to Java's way of doing things:
CHM::public boolean replace(K key, V oldValue, V newValue).

This is a HR java client specific issue, which ignores the flag and just returns a boolean. Not sure we want to go with this approach for all clients.

What others think?



> Conditional replace/remove not returning previous value in Java Hot Rod client
> ------------------------------------------------------------------------------
>
>                 Key: ISPN-1008
>                 URL: https://issues.jboss.org/browse/ISPN-1008
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Cache Server
>    Affects Versions: 4.2.1.FINAL, 5.0.0.ALPHA3
>            Reporter: Galder Zamarreño
>            Assignee: Mircea Markus
>             Fix For: 5.0.0.CR2, 5.0.0.FINAL
>
>
> The following RemoteCache APIs (and their variants) are not correctly defined:
> boolean replaceWithVersion(K key, V newValue, long version);
> boolean removeWithVersion(K key, long version);
> The protocol allows for the previous value to be returned if Flag.FORCE_RETURN_VALUE is used, and these APIs do not accomodate that.
> We should think whether it makes sense to keep the protocol as is. Does returning previous value help at all with conditional operations like these?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira