[infinispan-issues] [JBoss JIRA] Issue Comment Edited: (ISPN-1385) JDK7 CI job bringing CI to a halt

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628310#comment-12628310 ] 

Galder Zamarreño edited comment on ISPN-1385 at 9/14/11 4:25 AM:
-----------------------------------------------------------------

The difference between JDK6 and JDK7 could be in the reflection provider used:

- With JDK6, com.thoughtworks.xstream.converters.reflection.Sun14ReflectionProvider is used.
- With JDK7, com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider is used.

With JDK6 it all works fine, but the one chosen for JDK7 causes issues. And you know the reason for it? The following method returns false:

{code}
    private boolean canUseSun14ReflectionProvider() {
        return (isSun()
            || isApple()
            || isHPUX()
            || isIBM()
            || isBlackdown()
            || isBEAWithUnsafeSupport()
            || isHitachi()
            || isSAP() 
            || isDiablo())
            && is14()
            && loadClass("sun.misc.Unsafe") != null;
    }
{code}

And that's cause the vendor is no longer any of those but instead "Oracle Corporation" ;)

I bet we're gonna see a lot of code breaking due to assumptions like this with JDK7.

      was (Author: galder.zamarreno):
    The difference between JDK6 and JDK7 could be in the reflection provider used:

- With JDK6, com.thoughtworks.xstream.converters.reflection.Sun14ReflectionProvider is used.
- With JDK7, com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider is used.

With JDK6 it all works fine, but the one chosen for JDK7 causes issues. And you know the reason for it? The following method returns false:

{code}
    private boolean canUseSun14ReflectionProvider() {
        return (isSun()
            || isApple()
            || isHPUX()
            || isIBM()
            || isBlackdown()
            || isBEAWithUnsafeSupport()
            || isHitachi()
            || isSAP() 
            || isDiablo())
            && is14()
            && loadClass("sun.misc.Unsafe") != null;
    }
{code}

And that's cause the vendor is no longer any of those but instead Oracle ;)

I bet we're gonna see a lot of code breaking due to assumptions like this with JDK7.
  
> JDK7 CI job bringing CI to a halt
> ---------------------------------
>
>                 Key: ISPN-1385
>                 URL: https://issues.jboss.org/browse/ISPN-1385
>             Project: Infinispan
>          Issue Type: Task
>            Reporter: Galder Zamarreño
>            Assignee: Galder Zamarreño
>             Fix For: 5.1.0.ALPHA2 
>
>
> The JDK7 job brought CI to an standstill and Jenkins had to be restarted.
> It's unclear whether this is due to JDK7 itself, or due to the 68MB+ log that the job generates:
> https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK7-tcp/18/console
> The log should be reduced first, try running the testsuite and then enable the job in CI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira