[infinispan-issues] [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert

[Thomas Fromm (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714433#comment-12714433 ] 

Thomas Fromm edited comment on ISPN-686 at 8/29/12 9:08 AM:
------------------------------------------------------------

I took this one, since I need a optimization shortly. My simple approach is just execute Select ID w/o unmarshall maybe existing stuff to decide of insert/update should be used.

Bonus TODO: Encapsulate the select and insert/update into one transaction to avoid SQLIntegrityConstraintViolationExceptions...
                
      was (Author: tfromm):
    I took this one, since I need a optimization shortly. My simple approach is just execute Select ID w/o unmarshall maybe existing stuff to decide of insert/update should be used.
                  
> JdbcStringBasedCacheStore loads previous data from store before an insert
> -------------------------------------------------------------------------
>
>                 Key: ISPN-686
>                 URL: https://issues.jboss.org/browse/ISPN-686
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Loaders and Stores
>    Affects Versions: 4.0.0.Final, 4.1.0.Final
>            Reporter: Sanne Grinovero
>            Assignee: Thomas Fromm
>             Fix For: 5.2.0.Final
>
>
> The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find out if it should generate an UPDATE or INSERT statement, while it would perform much better to just verify if the primary key exists.
> On top of this, some databases provide ways to avoid the need to check at all, like MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
> [http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira