[infinispan-issues] [JBoss JIRA] (ISPN-1687) The method getDefaultCacheConfiguration gives incorrect cache configuration due to bugs in LegacyConfigurationAdaptor

[Nicolas Filotto (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654271#comment-12654271 ] 

Nicolas Filotto commented on ISPN-1687:
---------------------------------------

I confirm that the point #1 sounds OK now in the master, but point #2 is still incorrect as you can see https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/configuration/cache/StoreAsBinaryConfigurationBuilder.java
                
> The method getDefaultCacheConfiguration gives incorrect cache configuration due to bugs in LegacyConfigurationAdaptor
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISPN-1687
>                 URL: https://issues.jboss.org/browse/ISPN-1687
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Core API
>    Affects Versions: 5.1.0.CR2
>            Reporter: Nicolas Filotto
>            Assignee: Manik Surtani
>            Priority: Critical
>
> While upgrading my code to get rid of the deprecated Configuration object, I find several issues in the code such as:
> # in LegacyConfigurationAdaptor.adapt(org.infinispan.config.Configuration legacy): in several places you forgot to call explicitly enable() which is now required at least in case of invocationBatching and jmxStatistics
> # in StoreAsBinaryConfigurationBuilder.disable: the flag is set to true instead of false

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira