[infinispan-issues] [JBoss JIRA] (ISPN-2177) Refactor AbstractCacheTransaction

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708384#comment-12708384 ] 

Dan Berindei commented on ISPN-2177:
------------------------------------

Mircea, how about removing {{backupKeyLocks}} completely and using {{affectedKeys}}/{{clusterLockedKeys}} instead?
Is there any place where having a false positive is really a problem?
                
> Refactor AbstractCacheTransaction  
> -----------------------------------
>
>                 Key: ISPN-2177
>                 URL: https://issues.jboss.org/browse/ISPN-2177
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Transactions
>    Affects Versions: 5.1.2.FINAL
>            Reporter: Mircea Markus
>            Assignee: Mircea Markus
>              Labels: refactoring, transaction
>             Fix For: 5.2.0.FINAL
>
>
> There are several collections holding transaction related information in the AbstractCacheTransaction:
> - lockedKeys: this holds all the keys that were actually locked on the local node
> - affectedKeys: this holds all the keys that were acquired by the transaction allover the cluster
> - backupKeyLocks: this holds all the locks for which the local node is a secondary data owner.
> To do:
> - affectedKeys belongs to LocalCacheTransaction(subclass) and no point in having it in the AbstractCacheTransaction
> - a better name for affectedKeys might be "clusterLockedKey" and for lockedKeys --> localLokedKeys
> - also add a Javadoc explaining the correlation between these key groups

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira