[infinispan-issues] [JBoss JIRA] (ISPN-2044) Optimize marshalling of EnumSet<Flag>

[Sanne Grinovero (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693204#comment-12693204 ] 

Sanne Grinovero edited comment on ISPN-2044 at 5/16/12 6:25 AM:
----------------------------------------------------------------

I'd avoid wrapping, that takes more memory.
Taking for example PutKeyValueCommand, the Flags are transmitted to other nodes as part of

{code}
Object[] getParameters(){code}

still the command is extending org.infinispan.commands.AbstractFlagAffectedCommand
would it not be more sensible to invoke the Externalizer explicitly rather than letting River figure out the type from the Object[] stored reference? 
                
      was (Author: sannegrinovero):
    I'd avoid wrapping, that takes more memory.
Taking for example PutKeyValueCommand, the Flags are transmitted to other nodes as part pf

{code}
Object[] getParameters(){code}

still the command is extending org.infinispan.commands.AbstractFlagAffectedCommand
would it not be more sensible to invoke the Externalizer explicitly rather than letting River figure out the type from the Object[] stored reference? 
                  
> Optimize marshalling of EnumSet<Flag>
> -------------------------------------
>
>                 Key: ISPN-2044
>                 URL: https://issues.jboss.org/browse/ISPN-2044
>             Project: Infinispan
>          Issue Type: Enhancement
>          Components: Marshalling
>            Reporter: Sanne Grinovero
>            Assignee: Galder Zamarreño
>             Fix For: 5.2.0.FINAL
>
>
> When marshalling Flags, it looks like we could encode the whole EnumSet as a bitset, or use a different Marshaller ID for the empty enumset (which I'm assuming is a common case so worth optimizing for)
> See also thread: http://lists.jboss.org/pipermail/infinispan-dev/2012-May/010635.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira