[infinispan-issues] [JBoss JIRA] (ISPN-2546) StateChunk with isLastChunk=true not sent when all entries are sent ahead

[Adrian Nistor (JIRA)]

     [ https://issues.jboss.org/browse/ISPN-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Nistor updated ISPN-2546:
--------------------------------

              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/infinispan/infinispan/pull/1479

    
> StateChunk with isLastChunk=true not sent when all entries are sent ahead
> -------------------------------------------------------------------------
>
>                 Key: ISPN-2546
>                 URL: https://issues.jboss.org/browse/ISPN-2546
>             Project: Infinispan
>          Issue Type: Bug
>          Components: State transfer
>    Affects Versions: 5.2.0.Beta4
>            Reporter: Radim Vansa
>            Assignee: Adrian Nistor
>            Priority: Blocker
>
> During a state transfer the entries are sent batched to chunks. However, if all entries are sent in the non-last chunk, the list in entriesBySegment.get(segmentId) is empty. The code for sending last chunks is following:
> {code:title=OutboundTransferTask.sendEntries(...)}
> ...
> if (isLast) {
>          for (int segmentId : segments) {
>             List<InternalCacheEntry> entries = entriesBySegment.get(segmentId);
>             if (entries == null) {
>                chunks.add(new StateChunk(segmentId, InfinispanCollections.<InternalCacheEntry>emptyList(), true));
>             }
>          }
>       }
> ...
> {code}
> See that the check is {{entries == null}} but not {{entries.isEmpty()}}.
> This causes to leave some segments unfinished, never finishing the state transfer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira