[infinispan-issues] [JBoss JIRA] (ISPN-2396) For failing injected transactions, the rollback is incorrectly invoked

[Mircea Markus (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726222#comment-12726222 ] 

Mircea Markus commented on ISPN-2396:
-------------------------------------

Here's the buggy code from CacheImpl:

{code:java}
         try {
            transactionManager.commit();
         } catch (Throwable e) {
            log.couldNotCompleteInjectedTransaction(e);
            tryRollback();
            throw new CacheException("Could not commit implicit transaction", e);
         }
{code}

According to the JTA spec, after TransactionManager.commit() returns:"After the commit method returns, the calling thread is not associated with a transaction."
That means that the tryRolback will always fail, as thread's transaction association has been lost and there's no point in doing it. 
The effect of this is not much, as the only thing that happen is that a stack trace is logged with trace level.
                
> For failing injected transactions, the rollback is incorrectly invoked 
> -----------------------------------------------------------------------
>
>                 Key: ISPN-2396
>                 URL: https://issues.jboss.org/browse/ISPN-2396
>             Project: Infinispan
>          Issue Type: Feature Request
>    Affects Versions: 5.1.0.FINAL
>            Reporter: Mircea Markus
>            Assignee: Mircea Markus
>            Priority: Minor
>             Fix For: 5.2.0.CR1, 5.2.0.Final
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira