[infinispan-issues] [JBoss JIRA] (ISPN-2417) Topology check in LocalTransaction.getCommitNodes() is wrong

[Adrian Nistor (JIRA)]

Adrian Nistor created ISPN-2417:
-----------------------------------

             Summary: Topology check in LocalTransaction.getCommitNodes() is wrong
                 Key: ISPN-2417
                 URL: https://issues.jboss.org/browse/ISPN-2417
             Project: Infinispan
          Issue Type: Feature Request
          Components: State transfer, Transactions
    Affects Versions: 5.2.0.Beta2
            Reporter: Adrian Nistor
            Assignee: Mircea Markus
             Fix For: 5.2.0.CR1


Method LocalTransaction.getCommitNodes() was introduced when fixing ISPN-2317 but this aspect was overlooked during review.

The problem appears because the topology id is not incremented by an update caused by leavers. So the check getTopologyId() != currentTopologyId is not reliable.

Flagging this as an issue for now but maybe the fix will actually need to increment topologyId on every update, w/o any special treatment of leavers. That would automatically solve this issue and would also simplify the code in AbstractTxLockingInterceptor that solves the same problem as here (see usages of TransactionTable.useStrictTopologyIdComparison().

Or we can fix this here to using the same approach as AbstractTxLockingInterceptor + TransactionTable.useStrictTopologyIdComparison().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira