[infinispan-issues] [JBoss JIRA] (ISPN-2989) View rollback never unlocks stateTransferLock

[Dennis Reed (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764509#comment-12764509 ] 

Dennis Reed commented on ISPN-2989:
-----------------------------------

StateTransferLock#blockNewTransactions is called on a prepare from:
  CacheViewsManagerImpl#handlePrepareView
    -> BaseStateTransferManagerImpl#prepareView
      -> BaseStateTransferTask#performStateTransfer
        -> *#doPerformStateTransfer

StateTransferLock#unblockNewTransactions is called on a commit from:
  CacheViewsManagerImpl#handleCommitView
    -> BaseStateTransferManagerImpl#postInstallView

unblockNewTransactions is never called during a rollback!
It looks like BaseStateTransferManagerImpl#rollbackView should unblock it.
(just copy the unblock code from postInstallView).

                
> View rollback never unlocks stateTransferLock
> ---------------------------------------------
>
>                 Key: ISPN-2989
>                 URL: https://issues.jboss.org/browse/ISPN-2989
>             Project: Infinispan
>          Issue Type: Bug
>          Components: State transfer
>    Affects Versions: 5.1.7.Final
>            Reporter: Dennis Reed
>            Assignee: Mircea Markus
>
> When a new cache view prepare fails and is rolled back (for example due to a TimeoutException), the state transfer lock is never released, causing all future operations to fail with a StateTransferInProgressException timeout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira