[infinispan-issues] [JBoss JIRA] (ISPN-2161) InitiatorCrashPessimisticReplTest.testInitiatorNodeCrashesBeforeCommit fails randomly

[Pedro Ruivo (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787743#comment-12787743 ] 

Pedro Ruivo commented on ISPN-2161:
-----------------------------------

[~mircea.markus] [~galder.zamarreno]

I've start looking at this issue and I going to remove the InitiatorCrashPessimisticReplTest.testInitiatorNodeCrashesBeforeCommit because what is testing is invalid.

In pessimist caches, we have only phase (PrepareCommand with onePhaseCommit to true). So we only have two scenarios:
* initiator dies before prepare (covered in testInitiatorNodeCrashesBeforePrepare)
* initiator dies after prepare (covered in testInitiatorCrashesBeforeReleasingLock)

[~galder.zamarreno] I cannot see the link and I don't know if you remember, but is testInitiatorCrashesBeforeReleasingLock only failing in the Optimistic test?

Also, I will do a cleaning service: removing assert to AssertJUnit*, fork with callable, etc...
                
> InitiatorCrashPessimisticReplTest.testInitiatorNodeCrashesBeforeCommit fails randomly
> -------------------------------------------------------------------------------------
>
>                 Key: ISPN-2161
>                 URL: https://issues.jboss.org/browse/ISPN-2161
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Galder Zamarreño
>            Assignee: Pedro Ruivo
>              Labels: testsuite_stability
>             Fix For: 6.0.0.Alpha1, 6.0.0.Final
>
>         Attachments: testInitiatorNodeCrashesBeforeCommit-0.log
>
>
> Failed tests:   testInitiatorNodeCrashesBeforeCommit(org.infinispan.lock.singlelock.replicated.pessimistic.InitiatorCrashPessimisticReplTest): expected key 'k' to be locked on cache Cache '___defaultcache'@InitiatorCrashPessimisticReplTest-NodeD-44283, but it is not

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira