[infinispan-issues] [JBoss JIRA] (ISPN-3108) Server endpoint compatibility enhancements

[Galder Zamarreño (JIRA)]

     [ https://issues.jboss.org/browse/ISPN-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Galder Zamarreño updated ISPN-3108:
-----------------------------------

    Description: 
Several TODOs:

- Transaction's lookedUpEntries, affected and lockedKeys should use equivalent collections
- -Change equivalent hash set to be based on JSR-166- <- done in https://github.com/infinispan/infinispan/commit/c714c7785a302cb228bc8f293ce5eadc64dc125b
- -Make CollectionFactory a per cache component and contain references to key/value equivalence- <- deleted since it complicates the code and does not really add value
- figure out a way to have comparable ByteArrayEquivalence implementation and uncomment tests
- MetadataMortalCacheValue should extend MortalCacheValue, check others...
- EntryFactoryImpl.extractMetadata: "this is invoked from wrapEntryForPut and wrapEntryForReplace. Better make these two methods receive the metadata object directly from the caller, which is aware of these commands being MetadataAwareCommand, in order to avoid the not-so-nice instanceOf."
- Have `Builder lifespan(long time);` in Metadata builder interface and same for maxIdle.
- The simple cache.put(k,v) (and all other non-metadata bearing methods) create an immutable metadata object that always has the same (default) values for idle and expiry. This can be an single object instance instead of creating one per operation.

  was:
Several TODOs:

- Transaction's lookedUpEntries, affected and lockedKeys should use equivalent collections
- Change equivalent hash set to be based on JSR-166
- Make CollectionFactory a per cache component and contain references to key/value equivalence
- figure out a way to have comparable ByteArrayEquivalence implementation and uncomment tests
- MetadataMortalCacheValue should extend MortalCacheValue, check others...
- EntryFactoryImpl.extractMetadata: "this is invoked from wrapEntryForPut and wrapEntryForReplace. Better make these two methods receive the metadata object directly from the caller, which is aware of these commands being MetadataAwareCommand, in order to avoid the not-so-nice instanceOf."
- Have `Builder lifespan(long time);` in Metadata builder interface and same for maxIdle.
- The simple cache.put(k,v) (and all other non-metadata bearing methods) create an immutable metadata object that always has the same (default) values for idle and expiry. This can be an single object instance instead of creating one per operation.


    
> Server endpoint compatibility enhancements
> ------------------------------------------
>
>                 Key: ISPN-3108
>                 URL: https://issues.jboss.org/browse/ISPN-3108
>             Project: Infinispan
>          Issue Type: Enhancement
>            Reporter: Galder Zamarreño
>            Assignee: Galder Zamarreño
>             Fix For: 5.3.0.Final
>
>
> Several TODOs:
> - Transaction's lookedUpEntries, affected and lockedKeys should use equivalent collections
> - -Change equivalent hash set to be based on JSR-166- <- done in https://github.com/infinispan/infinispan/commit/c714c7785a302cb228bc8f293ce5eadc64dc125b
> - -Make CollectionFactory a per cache component and contain references to key/value equivalence- <- deleted since it complicates the code and does not really add value
> - figure out a way to have comparable ByteArrayEquivalence implementation and uncomment tests
> - MetadataMortalCacheValue should extend MortalCacheValue, check others...
> - EntryFactoryImpl.extractMetadata: "this is invoked from wrapEntryForPut and wrapEntryForReplace. Better make these two methods receive the metadata object directly from the caller, which is aware of these commands being MetadataAwareCommand, in order to avoid the not-so-nice instanceOf."
> - Have `Builder lifespan(long time);` in Metadata builder interface and same for maxIdle.
> - The simple cache.put(k,v) (and all other non-metadata bearing methods) create an immutable metadata object that always has the same (default) values for idle and expiry. This can be an single object instance instead of creating one per operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira