[infinispan-issues] [JBoss JIRA] (ISPN-3603) Conditional command is committed on originator when it fails on primary owner

[Pedro Ruivo (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12812446#comment-12812446 ] 

Pedro Ruivo commented on ISPN-3603:
-----------------------------------

[~rvansa] can you provide me some logs? 
I've spoken with [~dan.berindei] and I agree that the remoteGetBeforeWrite() can be remove safely but the entry should only be committed if it is marked as changed. However, it is only marked if the command succeeds. 
Do you know if concurrent updates are happening at the same time (or send me the logs to look at it)? 
                
> Conditional command is committed on originator when it fails on primary owner
> -----------------------------------------------------------------------------
>
>                 Key: ISPN-3603
>                 URL: https://issues.jboss.org/browse/ISPN-3603
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Distributed Cache
>    Affects Versions: 6.0.0.CR1
>            Reporter: Radim Vansa
>            Assignee: Pedro Ruivo
>            Priority: Critical
>              Labels: jdg62blocker
>
> In non-tx cache, when conditional command (e.g. ReplaceCommand) fails on primary owner because the old value is not equal to current value, the NonTxDistributionInterceptor.visitReplaceCommand returns false but the entry is committed in EntryWrappingInterceptor anyway.
> Speaking about EntryWrappingInterceptor.invokeNextAndApplyChanges: NonTxDistributionInterceptor does not mark the command as unsuccessful if it fails on the primary owner, therefore, checking for command.isSuccessful() in order to retry the command upon topology change may seem insufficient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira