[infinispan-issues] [JBoss JIRA] (ISPN-3571) Remote Query response missing numResults field in compatibility mode

[Adrian Nistor (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12808263#comment-12808263 ] 

Adrian Nistor commented on ISPN-3571:
-------------------------------------

I see the test registers server-side marshallers for org.infinispan.protostream.sampledomain which are client-side classes. In compat mode, the server should use the entities from org.infinispan.query.dsl.embedded.sample_domain_model and new marshallers should be created for these (trivial, just copy the existing ones). Please have a look at EmbeddedCompatTest.

But this test even though is wrong in current state is does indeed uncover a completely unrelated marshalling problem that I suspect is rooted in the protostream library (the missing numResults).
                
> Remote Query response missing numResults field in compatibility mode
> --------------------------------------------------------------------
>
>                 Key: ISPN-3571
>                 URL: https://issues.jboss.org/browse/ISPN-3571
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Querying
>    Affects Versions: 6.0.0.Beta2
>            Reporter: Martin Gencur
>            Assignee: Adrian Nistor
>             Fix For: 6.0.0.CR1
>
>
> Sample exception: 
> {code}
> testSampleDomainQuery2(org.infinispan.it.compatibility.RemoteQueryDslConditionsTest)  Time elapsed: 0.002 sec  <<< FAILURE!
> java.lang.IllegalStateException: Field numResults is required but is not present in the stream
> 	at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readPrimitive(ProtoStreamReaderImpl.java:176)
> 	at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readInt(ProtoStreamReaderImpl.java:188)
> 	at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:18)
> 	at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:13)
> 	at org.infinispan.protostream.impl.ProtoStreamReaderImpl.read(ProtoStreamReaderImpl.java:72)
> 	at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:45)
> 	at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:49)
> 	at org.infinispan.protostream.ProtobufUtil.fromByteArray(ProtobufUtil.java:53)
> 	at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:71)
> 	at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:26)
> 	at org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation.execute(RetryOnFailureOperation.java:46)
> 	at org.infinispan.client.hotrod.impl.query.RemoteQuery.executeQuery(RemoteQuery.java:79)
> 	at org.infinispan.client.hotrod.impl.query.RemoteQuery.list(RemoteQuery.java:69)
> 	at org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest.testSampleDomainQuery2(RemoteQueryDslConditionsTest.java:773)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:601)
> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> 	at org.testng.TestRunner.privateRun(TestRunner.java:767)
> 	at org.testng.TestRunner.run(TestRunner.java:617)
> 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> 	at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> 	at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> 	at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> 	at java.lang.Thread.run(Thread.java:722)
> {code}
> I'll attach tests shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira