[infinispan-issues] [JBoss JIRA] (ISPN-4178) 1PCs for synchronization enlistment should be invoked on beforeCompletion

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12959648#comment-12959648 ] 

Dan Berindei commented on ISPN-4178:
------------------------------------

This doesn't look like it would be very safe either, {{beforeCompletion()}} happens before the other XA resources in the transaction have even prepared, so it would be quite possible for Infinispan to commit and the other resource(s) in the transaction  to roll back. It would be nice if we could do this only if there are no other XA resources in the transaction, but I'm not sure if we can find out.

It's true that the user would see an exception in that case, though, so it might still be better than doing the commit in {{afterCompletion()}}. WDYT [~mircea.markus]?
                
> 1PCs for synchronization enlistment should be invoked on beforeCompletion
> -------------------------------------------------------------------------
>
>                 Key: ISPN-4178
>                 URL: https://issues.jboss.org/browse/ISPN-4178
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Transactions
>    Affects Versions: 5.2.8.Final
>            Reporter: Erik Salter
>            Assignee: Dan Berindei
>
> Because an afterCompletion is considered "best effort" and any exceptions would be swallowed by the transaction manager, any 1PC invocations should be done on the beforeCompletion() callback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira