[infinispan-issues] [JBoss JIRA] (ISPN-4178) 1PCs for synchronization enlistment should be invoked on beforeCompletion

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12959664#comment-12959664 ] 

Dan Berindei commented on ISPN-4178:
------------------------------------

Oops, we can't tell the TM that we actually committed the entry during {{beforeCompletion()}}, so if other resources roll back we'd still have to throw an exception during {{afterCompletion()}} to signal the error to the user - going back to the original problem.

I would suggest configuring Infinispan to register itself as a regular XA resource instead. If the performance of the TM writing its log to disk is a concern, I think using {{VolatileStore}} is a better option: https://github.com/infinispan/infinispan/blob/master/core/src/test/java/org/infinispan/test/fwk/JBossTransactionsUtils.java#L21
                
> 1PCs for synchronization enlistment should be invoked on beforeCompletion
> -------------------------------------------------------------------------
>
>                 Key: ISPN-4178
>                 URL: https://issues.jboss.org/browse/ISPN-4178
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Transactions
>    Affects Versions: 5.2.8.Final
>            Reporter: Erik Salter
>            Assignee: Dan Berindei
>
> Because an afterCompletion is considered "best effort" and any exceptions would be swallowed by the transaction manager, any 1PC invocations should be done on the beforeCompletion() callback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira