[infinispan-issues] [JBoss JIRA] (ISPN-4231) DistSyncL1FuncTest.testRemoteGetArrivesButWriteOccursBeforeRegistration random failures

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12963497#comment-12963497 ] 

Dan Berindei commented on ISPN-4231:
------------------------------------

[~william.burns] it seems to me that the BlockingInterceptors used in BaseDistL1FuncTest.testRemoteGetArrivesButWriteOccursBeforeRegistration should block before the command is performed, not after. Otherwise you can't guarantee that they will see the updated value:

{noformat}
14:39:03,957 INFO  (testng-DistSyncL1FuncTest:) [UnitTestTestNGListener] Starting test testRemoteGetArrivesButWriteOccursBeforeRegistration(org.infinispan.distribution.DistSyncL1FuncTest)
14:39:03,996 TRACE (transport-thread-NodeA-p13968-t3:dist) [InvocationContextInterceptor] Invoked with command GetKeyValueCommand {key=key-to-the-cache, flags=null} and InvocationContext [org.infinispan.context.SingleKeyNonTxInvocationContext at 370fa8ce]
14:39:03,996 TRACE (transport-thread-NodeA-p13968-t3:dist) [GetKeyValueCommand] Entry not found
14:39:03,996 TRACE (transport-thread-NodeA-p13968-t3:dist) [NonTxDistributionInterceptor] Doing a remote get for key key-to-the-cache
14:39:03,996 TRACE (OOB-2,NodeD-61213:) [InboundInvocationHandlerImpl] Calling perform() on ClusteredGetCommand{key=key-to-the-cache, flags=null}
14:39:03,997 TRACE (OOB-2,NodeD-61213:dist) [GetKeyValueCommand] Found entry ImmortalCacheEntry{key=key-to-the-cache, value=first-put}
14:39:03,997 TRACE (OOB-2,NodeD-61213:dist) [BlockingInterceptor] Command blocking after completion of GetKeyValueCommand {key=key-to-the-cache, flags=[CACHE_MODE_LOCAL, SKIP_REMOTE_LOOKUP]}
14:39:04,036 TRACE (OOB-1,NodeC-23789:) [InboundInvocationHandlerImpl] Calling perform() on ClusteredGetCommand{key=key-to-the-cache, flags=null}
14:39:04,036 TRACE (OOB-1,NodeC-23789:dist) [GetKeyValueCommand] Found entry ImmortalCacheEntry{key=key-to-the-cache, value=first-put}
14:39:04,036 TRACE (OOB-1,NodeC-23789:dist) [BlockingInterceptor] Command blocking after completion of GetKeyValueCommand {key=key-to-the-cache, flags=[CACHE_MODE_LOCAL, SKIP_REMOTE_LOOKUP]}
14:39:04,037 TRACE (OOB-1,NodeC-23789:dist) [BlockingInterceptor] Command completed blocking completion of GetKeyValueCommand {key=key-to-the-cache, flags=[CACHE_MODE_LOCAL, SKIP_REMOTE_LOOKUP]}
14:39:04,037 TRACE (OOB-1,NodeC-23789:dist) [EntryWrappingInterceptor] Entry for key key-to-the-cache is not changed(ImmortalCacheEntry{key=key-to-the-cache, value=second-put}): not calling commitUpdate
14:39:04,037 TRACE (OOB-2,NodeD-61213:dist) [BlockingInterceptor] Command completed blocking completion of GetKeyValueCommand {key=key-to-the-cache, flags=[CACHE_MODE_LOCAL, SKIP_REMOTE_LOOKUP]}
14:39:04,037 TRACE (OOB-1,NodeC-23789:) [InboundInvocationHandlerImpl] About to send back response SuccessfulResponse{responseValue=ImmortalCacheValue {value=second-put}}  for command ClusteredGetCommand{key=key-to-the-cache, flags=null}
14:39:04,037 TRACE (OOB-2,NodeD-61213:dist) [EntryWrappingInterceptor] Entry for key key-to-the-cache is not changed(ImmortalCacheEntry{key=key-to-the-cache, value=second-put}): not calling commitUpdate
14:39:04,037 TRACE (OOB-2,NodeD-61213:) [InboundInvocationHandlerImpl] About to send back response SuccessfulResponse{responseValue=ImmortalCacheValue {value=second-put}}  for command ClusteredGetCommand{key=key-to-the-cache, flags=null}
14:39:04,037 ERROR (testng-DistSyncL1FuncTest:) [UnitTestTestNGListener] Test testRemoteGetArrivesButWriteOccursBeforeRegistration(org.infinispan.distribution.DistSyncL1FuncTest) failed.
org.junit.ComparisonFailure: expected:<[second]-put> but was:<[first]-put>
{noformat}
                
> DistSyncL1FuncTest.testRemoteGetArrivesButWriteOccursBeforeRegistration random failures
> ---------------------------------------------------------------------------------------
>
>                 Key: ISPN-4231
>                 URL: https://issues.jboss.org/browse/ISPN-4231
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Test Suite - Core
>    Affects Versions: 7.0.0.Alpha3
>            Reporter: Dan Berindei
>            Assignee: William Burns
>              Labels: testsuite_stability
>             Fix For: 7.0.0.Alpha4
>
>
> {noformat}
> 14:39:04,037 ERROR (testng-DistSyncL1FuncTest:) [UnitTestTestNGListener] Test testRemoteGetArrivesButWriteOccursBeforeRegistration(org.infinispan.distribution.DistSyncL1FuncTest) failed.
> org.junit.ComparisonFailure: expected:<[second]-put> but was:<[first]-put>
> 	at org.junit.Assert.assertEquals(Assert.java:115)
> 	at org.junit.Assert.assertEquals(Assert.java:144)
> 	at org.infinispan.distribution.BaseDistSyncL1Test.testRemoteGetArrivesButWriteOccursBeforeRegistration(BaseDistSyncL1Test.java:342)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira