[infinispan-issues] [JBoss JIRA] (ISPN-4597) Query interceptor should update index during commit

[Sanne Grinovero (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989892#comment-12989892 ] 

Sanne Grinovero commented on ISPN-4597:
---------------------------------------

Dan, the {{visitCommitCommand}} has no access to the list of applied modifications, which really isn't optional to know what to do on the indexes.
Could core provide those details, or should we try stick this information somewhere during the prepare phase? Do you have suggestions to avoid leaks?

> Query interceptor should update index during commit
> ---------------------------------------------------
>
>                 Key: ISPN-4597
>                 URL: https://issues.jboss.org/browse/ISPN-4597
>             Project: Infinispan
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Embedded Querying
>    Affects Versions: 7.0.0.Alpha5
>            Reporter: Dan Berindei
>            Assignee: Sanne Grinovero
>             Fix For: 7.0.0.Beta1
>
>
> {{QueryInterceptor}} updates indexes during {{visitPrepareCommand}}. However, a tx that was prepared successfully is not guaranteed to be actually committed (e.g. if another node fails to prepare, or if another XA resource fails). The index should only be updated during {{visitPrepareCommand}} if the prepare is 1-phase, otherwise it should be updated during {{visitCommitCommand}}.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)