[infinispan-issues] [JBoss JIRA] (ISPN-4597) Query interceptor should update index during commit

[Sanne Grinovero (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989927#comment-12989927 ] 

Sanne Grinovero commented on ISPN-4597:
---------------------------------------

[~dan.berindei] I could not reproduce it. Where did you see this behaviour? 

I'm testing with this configuration:

{code}ConfigurationBuilder cfg = getDefaultStandaloneCacheConfig(true);
      cfg
         .customInterceptors()
            .addInterceptor()
               .after(EntryWrappingInterceptor.class)
               .interceptor(nastyInterceptor)
         .transaction()
            .transactionMode(TransactionMode.TRANSACTIONAL)
            .use1PcForAutoCommitTransactions(false)
         .indexing()
            .index(Index.ALL)
            .addProperty("default.directory_provider", "ram")
            .addProperty("lucene_version", "LUCENE_CURRENT");{code}

and could verify via debugger that it's applying the two-phase strategy, still if I have it blow up after the prepare but before the commit, the write operations are not applied to the index.

> Query interceptor should update index during commit
> ---------------------------------------------------
>
>                 Key: ISPN-4597
>                 URL: https://issues.jboss.org/browse/ISPN-4597
>             Project: Infinispan
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Embedded Querying
>    Affects Versions: 7.0.0.Alpha5
>            Reporter: Dan Berindei
>            Assignee: Sanne Grinovero
>             Fix For: 7.0.0.Beta1
>
>
> {{QueryInterceptor}} updates indexes during {{visitPrepareCommand}}. However, a tx that was prepared successfully is not guaranteed to be actually committed (e.g. if another node fails to prepare, or if another XA resource fails). The index should only be updated during {{visitPrepareCommand}} if the prepare is 1-phase, otherwise it should be updated during {{visitCommitCommand}}.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)