[infinispan-issues] [JBoss JIRA] (ISPN-4597) Query interceptor should update index during commit

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990169#comment-12990169 ] 

Dan Berindei commented on ISPN-4597:
------------------------------------

I haven't really seen problems in a test, I was just reading the QueryInterceptor code and thought it was unusual that the {{visitCommitCommand}} method didn't do anything.

> Query interceptor should update index during commit
> ---------------------------------------------------
>
>                 Key: ISPN-4597
>                 URL: https://issues.jboss.org/browse/ISPN-4597
>             Project: Infinispan
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Embedded Querying
>            Reporter: Dan Berindei
>            Assignee: Sanne Grinovero
>
> {{QueryInterceptor}} updates indexes during {{visitPrepareCommand}}. However, a tx that was prepared successfully is not guaranteed to be actually committed (e.g. if another node fails to prepare, or if another XA resource fails). The index should only be updated during {{visitPrepareCommand}} if the prepare is 1-phase, otherwise it should be updated during {{visitCommitCommand}}.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)