[infinispan-issues] [JBoss JIRA] (ISPN-4520) JdbcBinaryStoreTest.testLoadAndStoreWithLifespanAndIdle random failures

[Pedro Ruivo (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987955#comment-12987955 ] 

Pedro Ruivo commented on ISPN-4520:
-----------------------------------

the problem is in the test. the idle/lifespan is so small that the entry is not stored in the database (https://github.com/infinispan/infinispan/blob/master/persistence/jdbc/src/main/java/org/infinispan/persistence/jdbc/binary/JdbcBinaryStore.java#L123)

I'll take this opportunity to refactor the tests (remove all the assert keywords, duplicated code, mock the cache, etc...) and I'll introduce a new TimeService to control when the entries are expired or not (and remove all the timeouts and sleeps).

However, the osgi environment don't like my refactor for some reason :/

> JdbcBinaryStoreTest.testLoadAndStoreWithLifespanAndIdle random failures
> -----------------------------------------------------------------------
>
>                 Key: ISPN-4520
>                 URL: https://issues.jboss.org/browse/ISPN-4520
>             Project: Infinispan
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Core, Test Suite - Core
>    Affects Versions: 7.0.0.Alpha4
>            Reporter: Dan Berindei
>            Assignee: Pedro Ruivo
>            Priority: Blocker
>              Labels: testsuite_stability
>             Fix For: 7.0.0.Alpha5
>
>
> I think the 1s timeout is a bit small for the CI machine:
> {noformat}
> java.lang.IllegalStateException: Purge has timed out
>     at org.infinispan.persistence.BaseStoreTest.purgeExpired(BaseStoreTest.java:268)
> {noformat}
> The other methods using {{BaseStoreTest.purgeExpired}} and the other tests extending BaseStoreTest probably have the same problem.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)