[infinispan-issues] [JBoss JIRA] (ISPN-4092) ViewChangedEvent.getOldMembers() and getNewMembers() should never be null

[Eric Bonnot (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12951845#comment-12951845 ] 

Eric Bonnot commented on ISPN-4092:
-----------------------------------

The modification of those two functions in the class org.infinispan.notifications.cachemanagerlistener.event.EventImpl doesn't work : there is now a test to check if the lists are null or not, and if they are a new list is created, but the new list is never affected or returned.

Should it be : 
@Override
public List<Address> getNewMembers() {
   if(newMembers == null){
      this.newMembers = InfinispanCollections.emptyList();
   }
   return this.newMembers;
}

and :
@Override
public List<Address> getOldMembers() {
   if(oldMembers == null){
      this.oldMembers = InfinispanCollections.emptyList();
   }
   return this.oldMembers;
}

                
> ViewChangedEvent.getOldMembers() and getNewMembers() should never be null
> -------------------------------------------------------------------------
>
>                 Key: ISPN-4092
>                 URL: https://issues.jboss.org/browse/ISPN-4092
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 6.0.1.Final
>            Reporter: Eric Bonnot
>            Assignee: Thomas Fromm
>            Priority: Minor
>
> Simply for more comfort at usage I'd like to have ViewChangedEvent changed, that the list-getter never return null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira