[infinispan-issues] [JBoss JIRA] (ISPN-4092) ViewChangedEvent.getOldMembers() and getNewMembers() should never be null

[Eric Bonnot (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12952086#comment-12952086 ] 

Eric Bonnot commented on ISPN-4092:
-----------------------------------

Well, yes, I haven't noticed that when I cloned the previous issue... But it reveals that Infinispan issues are strongly monitored (thank you for your quick reply) !

So maybe :

@Override
public List<Address> getNewMembers() {
   if(this.newMembers == null){
      this.setNewMembers(InfinispanCollections.emptyList());
   }
   return this.newMembers;
}

public synchronized void setNewMembers(List<Address> newMembers) {
   this.newMembers = newMembers;
}

public synchronized void setOldMembers(List<Address> oldMembers) {
   this.oldMembers = oldMembers;
}

@Override
public List<Address> getOldMembers() {
   if(this.oldMembers == null){
      this.setOldMembers(InfinispanCollections.emptyList());
   }
   return this.oldMembers;
}

And maybe :

public synchronized void setSubgroupsMerged(List<List<Address>> subgroupsMerged) {
   this.subgroupsMerged = subgroupsMerged;
}

@Override
public List<List<Address>> getSubgroupsMerged() {
   if(this.subgroupsMerged== null){
      this.setSubgroupsMerged(InfinispanCollections.emptyList());
   }
   return this.subgroupsMerged;
}

                
> ViewChangedEvent.getOldMembers() and getNewMembers() should never be null
> -------------------------------------------------------------------------
>
>                 Key: ISPN-4092
>                 URL: https://issues.jboss.org/browse/ISPN-4092
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 6.0.1.Final
>            Reporter: Eric Bonnot
>            Assignee: Thomas Fromm
>            Priority: Minor
>
> Simply for more comfort at usage I'd like to have ViewChangedEvent changed, that the list-getter never return null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira