[infinispan-issues] [JBoss JIRA] (ISPN-4677) Map/Reduce job fails with the wrong explanation on underlying TimeoutException

[Vladimir Blagojevic (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998260#comment-12998260 ] 

Vladimir Blagojevic commented on ISPN-4677:
-------------------------------------------

Sanne, thank you! I am inclined to simplify this by throwing exception rather than adding some flag:

throw new ExecutionException("Map phase executing at " + mapTaskPart.getAddress() + " timed out", cause);

Exception cause will provide the details, it could be Node timed out like in your example or it could be one of the "Timed out waiting for valid responses!" exception. Both cases will be covered and the code will be future proofed. WDYT?

> Map/Reduce job fails with the wrong explanation on underlying TimeoutException
> ------------------------------------------------------------------------------
>
>                 Key: ISPN-4677
>                 URL: https://issues.jboss.org/browse/ISPN-4677
>             Project: Infinispan
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Distributed Execution and Map/Reduce
>    Affects Versions: 7.0.0.Beta1
>            Reporter: Sanne Grinovero
>            Assignee: Vladimir Blagojevic
>             Fix For: 7.0.0.Beta2
>
>
> I'm running a task which is throwing the following exception during the Map phase:
> {noformat}
> org.infinispan.util.concurrent.TimeoutException: Node main-NodeC-22183 timed out{noformat}
> The user facing error however is this very confusing message:
> {noformat}org.infinispan.commons.CacheException: java.util.concurrent.ExecutionException: Map phase executing at main-NodeA-39904 did not complete within 0 sec timeout{noformat}
> I have no timeout enabled.
> The problem is the instanceof operation on the cause of the error in org.infinispan.distexec.mapreduce.MapReduceTask.executeMapPhaseWithLocalReduction(Map<KOut, VOut>): the check on the type only is not good enough.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)