[infinispan-issues] [JBoss JIRA] (ISPN-3868) Deadlock in RemoteCache getAsync

[Alan Feng (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004374#comment-13004374 ] 

Alan Feng commented on ISPN-3868:
---------------------------------

May I ask why the fix for this critical issue is not back ported to the 6.x releases, which is used in most of places?

> Deadlock in RemoteCache getAsync
> --------------------------------
>
>                 Key: ISPN-3868
>                 URL: https://issues.jboss.org/browse/ISPN-3868
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 6.0.0.Final
>         Environment: RemoteCahe component of 6.0.0.Final 
>            Reporter: Alexander Furer
>            Assignee: Mircea Markus
>              Labels: 630, remote
>             Fix For: 7.0.0.Alpha1, 7.0.0.Final
>
>
> Here is the implementation of remoteCahe.getAsync() :
> {code}
>  public NotifyingFuture<V> getAsync(final K key) {
>       assertRemoteCacheManagerIsStarted();
>       final NotifyingFutureImpl<V> result = new NotifyingFutureImpl<V>();
>       Future<V> future = executorService.submit(new Callable<V>() {
>          @Override
>          public V call() throws Exception {
>             V toReturn = get(key);
>             result.notifyFutureCompletion();
>             return toReturn;
>          }
>       });
>       result.setExecuting(future);
>       return result;
>    }
> {code}
> 2 problems here :
> 1. Callable's call method might be called BEFORE calling client had a chance to add listener (i.e. getAsync is not returned yet), in this case its' listener futureDone method  will never be called.
> 2. Even case #1 has not happened and  notifyFutureCompletion is called on listener, but the future is not  resolved yet : "call" has not returned, that's why the future that is passed to listener is  not resolved, and calling future.get from listener blocks forever.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)