[infinispan-issues] [JBoss JIRA] (ISPN-3905) Murmurhash3 implementation is slow on String keys

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136100#comment-13136100 ] 

Dan Berindei commented on ISPN-3905:
------------------------------------

I wonder if applications are really reusing String instances to use as cache keys. I would expect most application to use composite keys, by concatenating multiple strings and/or primitives, and never to reuse the concatenated string instances.

> Murmurhash3 implementation is slow on String keys
> -------------------------------------------------
>
>                 Key: ISPN-3905
>                 URL: https://issues.jboss.org/browse/ISPN-3905
>             Project: Infinispan
>          Issue Type: Enhancement
>          Components: Core
>    Affects Versions: 6.0.0.Final, 6.0.1.Final
>            Reporter: Sanne Grinovero
>            Assignee: Dan Berindei
>            Priority: Minor
>             Fix For: 8.1.0.Final
>
>
> String instances are a common choice for being used as key entries, still the getBytes() operation being performed allocates costly buffers, and the computation to get those bytes looks like expensive too.
> I suspect there might be good reasons for not using the String's own hashcode directly as an input to Murmurhash? Still that's what other implementations seem to do.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)