[infinispan-issues] [JBoss JIRA] (ISPN-5131) Deploy custom cache store to Infinispan Server

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039737#comment-13039737 ] 

Galder Zamarreño commented on ISPN-5131:
----------------------------------------

Indeed you don't want to limit users deploying instances of AdvancedLoadWriteStore only. You want to support deploying AdvancedCacheLoader, CacheLoader, AdvancedCacheWriter, CacheWriter and ExternalStore as well. This should be tested to make sure it works as expected. Ideally, you'd make sure you can support all of these with the least amount of internal changes. It will require though supporting multiple META-INF/services/xxx definitions based on which interface the user decides to implement.

org.infinispan.server.endpoint.subsystem.EndpointSubsystemAdd defines at which point the processors run, by defining the phase at which to run. That's what makes sure that filters and converters are processed after they've been deployed and not earlier.

Looks good otherwise! Indeed, use filter/converters deployment work as template for this :)

> Deploy custom cache store to Infinispan Server
> ----------------------------------------------
>
>                 Key: ISPN-5131
>                 URL: https://issues.jboss.org/browse/ISPN-5131
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Loaders and Stores, Server
>            Reporter: Tristan Tarrant
>            Assignee: Sebastian Łaskawiec
>             Fix For: 7.2.0.Final
>
>
> h2. Overview
> Support the deployment and configuration of a custom cache store.
> h2. Client Perspective
> In order to create a deployable Cache Store the client will have to implement {{AdvancedLoadWriteStoreFactory}} (which will contain factory methods for creating {{AdvancedLoadWriteStore}}). Next, the factory will have to be annotated with {{@NamedFactory}} and placed into a jar together with proper entry of {{META-INF/services/org.infinispan.persistence.AdvancedLoadWriteStoreFactory}}. The last activity is to deploy given jar into Hotrod server.
> h2. Implementation overview
> The implementation is based on Deployable Filters and Converters. 
> Currently all writers and loaders are instantiated in {{PersistenceManagerImpl#createLoadersAndWriters}}. This implementation will be modified to use {{LoadWriteStoreRegistry}}, which will contain a list of {{AdvancedLoadWriteStoreFactories}}. One of the factories will be added by default - the local one (which will the same mechanism as we do now - {{Util.getInstance(classAnnotation)}}. Other {{AdvancedLoadWriteStoreFactories}} will be added after deployment scanning.
> h2. Implementation doubts and questions:
> * Should we expose a factory for {{AdvancedLoadWriteStore}} or should we include also {{ExternalStore}} (or even separate factory for {{CacheLoader}} and {{CacheWriter}}?
> * How to ensure that deployment scanning has finished before creating instantiating {{AdvancedLoadWriteStore}}?



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)