[infinispan-issues] [JBoss JIRA] (ISPN-5564) AsyncCacheWriter stop() and clear() should not wait for space in the modifications queue

[Karsten Blees (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083214#comment-13083214 ] 

Karsten Blees edited comment on ISPN-5564 at 6/24/15 8:03 AM:
--------------------------------------------------------------

{quote}I'm wondering if this really matters for {{stop()}}.{quote}

It may save another empty State on shutdown. But it is indeed quite unlikely that the buffer is completely full after passivation. So for {{stop()}} its more a cosmetic change.


was (Author: kblees):
> I'm wondering if this really matters for `stop()`.

It may save another empty State on shutdown. But it is indeed quite unlikely that the buffer is completely full after passivation. So for `stop()` its more a cosmetic change.

> AsyncCacheWriter stop() and clear() should not wait for space in the modifications queue
> ----------------------------------------------------------------------------------------
>
>                 Key: ISPN-5564
>                 URL: https://issues.jboss.org/browse/ISPN-5564
>             Project: Infinispan
>          Issue Type: Enhancement
>            Reporter: Karsten Blees
>             Fix For: 8.0.0.Beta1, 7.2.4.Final
>
>
> AsyncCacheWriter.clear() invalidates all enqueued changes rather than adding more changes to the queue. Thus, clear should not wait if the queue is full.
> AsyncCacheWriter.stop() should also take effect immediately (i.e. set the stopped flag *without* waiting if the queue is full).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)