[infinispan-issues] [JBoss JIRA] (ISPN-5667) Unify isExpired for time and entries

[William Burns (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108678#comment-13108678 ] 

William Burns commented on ISPN-5667:
-------------------------------------

This isn't directly related, but I just noticed this may be an issue.  The ExpiryHelper adds the created and lifespan values together.  This could cause a numeric overflow if the lifespan is especially large which will in turn expire the entry early.

> Unify isExpired for time and entries
> ------------------------------------
>
>                 Key: ISPN-5667
>                 URL: https://issues.jboss.org/browse/ISPN-5667
>             Project: Infinispan
>          Issue Type: Bug
>            Reporter: Radim Vansa
>
> {{DefaultTimeService.isTimeExpired()}} is implemented using non-strict comparison:
> {code}
> time() - endTime >= 0
> {code}
> while expiration of entries in {{ExpiryHelper}} uses strict one:
> {code}
> now > created + lifespan
> {code}
> I don't know which one should be the correct one, probably fixing this in TimeService will cause less trouble.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)