[infinispan-issues] [JBoss JIRA] (ISPN-3690) Lower allocation cost of instances of org.infinispan.commands.read.GetKeyValueCommand

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13341422#comment-13341422 ] 

Dan Berindei commented on ISPN-3690:
------------------------------------

This was actually implemented with ISPN-5032.

TBH I'm not very fond of the extra {{InternalEntryFactory}} reference in {{GetCacheEntryCommand}}. It's used to synchronize on the cache entry, but why does {{GetCacheEntryCommand}} need to copy the entry fields atomically while the rest of our code non-atomically reads the value and the metadata separately?


> Lower allocation cost of instances of org.infinispan.commands.read.GetKeyValueCommand
> -------------------------------------------------------------------------------------
>
>                 Key: ISPN-3690
>                 URL: https://issues.jboss.org/browse/ISPN-3690
>             Project: Infinispan
>          Issue Type: Enhancement
>          Components: Core
>            Reporter: Sanne Grinovero
>            Priority: Minor
>              Labels: performance
>
> Classes of type {code}org.infinispan.commands.read.GetKeyValueCommand{code} have an high cost in terms of memory allocation.
> Would be great if we could reduce the runtime cost: in an app server test of just 25 minutes - which is stressing way more systems than just Infinispan - just the occasional get operations 43GB of memory accumulated over time.
> This is a high cost on the TLABs, skewing various other values, among others making the default GC options unsuitable.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)