[infinispan-issues] [JBoss JIRA] (ISPN-7704) AbstractFileLookup#lookupFileStrict should also support absolute paths

[Daniel Svanström (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13394544#comment-13394544 ] 

Daniel Svanström commented on ISPN-7704:
----------------------------------------

I just had a look at the fix of this issue. I built 9.0.1-SNAPSHOT locally, which should include this fix. I confirm that the error that occurred before went away. However, something still seems to be incorrect here. While Infinispan init seems like it checks for the existence of the infinispan.xml configuration(it complains loudly if it can't find the file), the init does not seem to care at all about the contents of the file. To show what I mean, I have updated my test case at https://github.com/DBarbarian/CacheTest/tree/master with a unit test. To see the issue, look in the application.properties file and play around with the three different configurations.

* When pointing at the correct configuration file, there is no error at init (expected), but my configured caches do not get initialized (not expected) as it can't find the cache when it is about t be used.
* When pointing at a non-existing configuration file, I get an error during init (expected).
* When pointing at an existing configuration file with invalid xml, I get no errors during init (unexpected).

I have also [included the same unit test for the 8.2.6 version|https://github.com/DBarbarian/CacheTest/tree/infinispan-8.2.6-testcase], where the only difference is which version of Infinispan the code is using but the behavior is what I would expect.

> AbstractFileLookup#lookupFileStrict should also support absolute paths
> ----------------------------------------------------------------------
>
>                 Key: ISPN-7704
>                 URL: https://issues.jboss.org/browse/ISPN-7704
>             Project: Infinispan
>          Issue Type: Bug
>          Components: JCache, Spring Integration
>    Affects Versions: 9.0.0.Final
>            Reporter: Sebastian Łaskawiec
>            Assignee: Sebastian Łaskawiec
>            Priority: Critical
>             Fix For: 9.0.1.Final
>
>
> When specifying {{spring.cache.jcache.config}} value in Spring's application.properties, Spring passes us a scheme with absolute path (e.g. {{file:/home/slaskawi/work/infinispan/CacheTest/target/classes/infinispan.xml}}). This causes problems with {{AbstractFileLookup#lookupFileStrict(java.net.URI, java.lang.ClassLoader)}} since it should construct a new {{File}} rather than load this resource from the classloader.
> Related Pull Request: https://github.com/infinispan/infinispan/pull/4474



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)