[infinispan-issues] [JBoss JIRA] (ISPN-7431) Remove VisitableCommand.shouldInvoke()

[Dan Berindei (JIRA)]

     [ https://issues.jboss.org/browse/ISPN-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Berindei updated ISPN-7431:
-------------------------------
              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/infinispan/infinispan/pull/4826


{{VisitableCommand.ignoreCommandOnStatus()}} is very similar, so the pull request removes them both.

At some point, both helped reduce the number of exceptions thrown for commands executing while the cache is stopping, but it don't eliminate them completely. It's better to check the cache status after the exception was thrown, and only log the exception if the cache is running.

> Remove VisitableCommand.shouldInvoke()
> --------------------------------------
>
>                 Key: ISPN-7431
>                 URL: https://issues.jboss.org/browse/ISPN-7431
>             Project: Infinispan
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 9.0.0.Beta2
>            Reporter: Dan Berindei
>            Assignee: Dan Berindei
>             Fix For: 9.0.0.CR1
>
>
> {{VisitableCommand.shouldInvoke()}} is only implemented non-trivially in {{InvalidateL1Command}}. But that check only helps while the cache is rebalancing, and even then the impact is negligible.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)