[infinispan-issues] [JBoss JIRA] (ISPN-7933) Investigate moving the request id from a message header to the buffer

[Pedro Ruivo (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422273#comment-13422273 ] 

Pedro Ruivo commented on ISPN-7933:
-----------------------------------

I would go for a {{InfinispanHeader}} with request-id + cache-name for the following reasons:

* remove the cache name from commands
* remove {{CacheRpcCommand}} 
* Debug info in JGroups protocol
* don't interact with marshaller (lookup externalizers)
* we know what cache we are going to hit before unmarshall the command
* we may possible do some application batch without repeating the cache-name

The only disadvantage is we need to add the {{ByteString}} to the {{invokeCommand*}} methods in {{Transport}} (when null, assume a global command)

> Investigate moving the request id from a message header to the buffer
> ---------------------------------------------------------------------
>
>                 Key: ISPN-7933
>                 URL: https://issues.jboss.org/browse/ISPN-7933
>             Project: Infinispan
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 9.1.0.Alpha1
>            Reporter: Dan Berindei
>            Assignee: Dan Berindei
>
> The ISPN-6971 pull request removes the usage of JGroups' {{MessageDispatcher}}, but keeps using {{RequestCorrelator.Header}} to put the request id in the message. We could eliminate the header allocation and put the request id in the buffer.
> OTOH having a separate header means the request id is visible in the logs of various JGroups protocols, so we may want to only replace {{RequestCorrelator.Header}} with our own header class.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)