[infinispan-issues] [JBoss JIRA] (ISPN-7556) Decoder2x.readOptionalParams should not call markReaderIndex()

[Sebastian Łaskawiec (JIRA)]

     [ https://issues.jboss.org/browse/ISPN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Łaskawiec updated ISPN-7556:
--------------------------------------
        Status: Resolved  (was: Pull Request Sent)
    Resolution: Done


> Decoder2x.readOptionalParams should not call markReaderIndex()
> --------------------------------------------------------------
>
>                 Key: ISPN-7556
>                 URL: https://issues.jboss.org/browse/ISPN-7556
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 9.0.0.CR2
>            Reporter: Dan Berindei
>            Assignee: Dan Berindei
>             Fix For: 9.0.0.CR3
>
>
> {{Decoder2x.readOptionalParams()}} calls {{buffer.markReaderIndex()}} after reading each parameter, but doesn't save the parameters anywhere. That means if the buffer doesn't contain all the parameters, the decode pass ends unsuccessfully, and the next decode pass doesn't see the parameters read by the previous pass.
> Higher-level methods like {{Decoder2x.readMaybeNamedFactory()}} also call {{readOptionalParams()}} without saving their own state first, meaning their state can be lost as well.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)