[infinispan-issues] [JBoss JIRA] (ISPN-8740) Refactor backup-write commands (triangle)

[Radim Vansa (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526698#comment-13526698 ] 

Radim Vansa edited comment on ISPN-8740 at 1/31/18 9:46 AM:
------------------------------------------------------------

I prefer to decouple backup commands from regular commands, that's why I've suggested to link them through helpers rather than adding extra methods to interfaces.

These helpers also keep all the lambdas together, so once you start passing >= 3 parameters ([like here|https://github.com/infinispan/infinispan/commit/74f4c8962cfad0e406e18652aa164d5e2ea63d3c#diff-b9d8ec6a9fbcb60ca8255e5fff2108c4R165]) it makes passing these more compact. Not that it would be applicable everywhere.



was (Author: rvansa):
I prefer to decouple backup commands from regular commands, that's why I've suggested to link them through helpers rather than adding extra methods to interfaces.

These helpers also keep all the lambdas together, so once you start passing > 3 parameters ([like here|https://github.com/infinispan/infinispan/commit/74f4c8962cfad0e406e18652aa164d5e2ea63d3c#diff-b9d8ec6a9fbcb60ca8255e5fff2108c4R165]) it makes passing these more compact. Not that it would be applicable everywhere.


> Refactor backup-write commands (triangle)
> -----------------------------------------
>
>                 Key: ISPN-8740
>                 URL: https://issues.jboss.org/browse/ISPN-8740
>             Project: Infinispan
>          Issue Type: Enhancement
>            Reporter: Pedro Ruivo
>            Assignee: Pedro Ruivo
>
> h2. Split the backup commands
> * single key
> * single key, functional
> * put map
> * entries functional
> * keys functional
> h2. Remove method from {{WriteCommand}} interface (Radim's suggestion)
> * Use helper methods to create the backup-write commands. (note. I'm not sure if it makes much sense)



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)