[infinispan-issues] [JBoss JIRA] (ISPN-8974) Avoid JBossMarshaller instance caches growing limitless

[Richard Janík (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-8974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551225#comment-13551225 ] 

Richard Janík commented on ISPN-8974:
-------------------------------------

I'm looking at the code differences between 8.2.8.Final and current master (9.2.1-SNAPSHOT, 5d3d2f1c0a3c41d60158d2b771d43abb3d4a5233). It looks like the marshallers and unmarshallers are still cached per thread and the {{removeMarshaller/removeUnmarshaller}} logic is the same in master. I'll clone the issue for 9.x, if that's ok. If there's a difference in design in 9.x that I'm not aware that fixes this, please let me know and just close the new issue. Thanks!

Cc [~mvinkler]

> Avoid JBossMarshaller instance caches growing limitless
> -------------------------------------------------------
>
>                 Key: ISPN-8974
>                 URL: https://issues.jboss.org/browse/ISPN-8974
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Marshalling
>    Affects Versions: 8.2.10.Final
>            Reporter: Galder Zamarreño
>            Assignee: Galder Zamarreño
>              Labels: downstream_dependency
>
> In the 8.2.x design, JBoss Marshaller marshaller/unmarshaller instances were cached in thread locals to speed up things. Internally it instance caches are kept which never shrink. This can create leaks.
> We should change the code so that when releasing marshallers/unmarshaller, if instance cache is bigger than certain size, destroy the marshaller and let it recreate it. A good size to not go beyond would be 1024, given that in 8.2.x we configure JBoss Marshaller instance count to 32.
> This would require Infinispan code to access and check instance cache size.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)