[infinispan-issues] [JBoss JIRA] (ISPN-9861) Marshallers for remote querying should be public

[Adrian Nistor (Jira)]

    [ https://issues.jboss.org/browse/ISPN-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680615#comment-13680615 ] 

Adrian Nistor commented on ISPN-9861:
-------------------------------------

Many classes in org.infinispan.query.remote.client package should have been placed in org.infinispan.query.remote.client.impl to be hidden away from the user.
They are public for other reasons than being a public API. So I'm not very keen to make even more things public here.  
Only BaseProtoStreamMarshaller and relatives should be public. 

Can't MarshallerRegistration be used for the purpose you intend [~william.burns]?

> Marshallers for remote querying should be public
> ------------------------------------------------
>
>                 Key: ISPN-9861
>                 URL: https://issues.jboss.org/browse/ISPN-9861
>             Project: Infinispan
>          Issue Type: Task
>          Components: Remote Querying
>            Reporter: William Burns
>            Assignee: William Burns
>            Priority: Major
>             Fix For: 10.0.0.Beta1
>
>
> There are a number of marshallers that are registered to enable remote querying. These classes are currently only enabled via {code}MarshallerRegistration#registerMarshallers{code} method. These classes should be public to allow other methods if needed.
> The marshallers used are currently:
> {code}
>       ctx.registerMarshaller(new QueryRequest.NamedParameter.Marshaller());
>       ctx.registerMarshaller(new QueryRequest.Marshaller());
>       ctx.registerMarshaller(new QueryResponse.Marshaller());
>       ctx.registerMarshaller(new FilterResult.Marshaller());
>       ctx.registerMarshaller(new ContinuousQueryResult.ResultType.Marshaller());
>       ctx.registerMarshaller(new ContinuousQueryResult.Marshaller());
> {code}
> Note that the classes that are marshalled by these are all public, so there shouldn't be any harm in changing the visibility.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)