[infinispan-issues] [JBoss JIRA] (ISPN-9863) Testsuite leaks threads

[Dan Berindei (Jira)]

     [ https://issues.jboss.org/browse/ISPN-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Berindei updated ISPN-9863:
-------------------------------
    Status: Pull Request Sent  (was: Reopened)


Needed an update because it wasn't always catching leaks in the spring5 modules, depending on whether the last test to run called TestResourceTracker or not. This made me change the strategy a bit in a new PR:

* Move leak detection to a @AfterSuite configuration method.
  That way leak detection works even if the last test does not
  extend AbstractInfinispanTest.
* Also move detection of wrong/missing groups or testName
  to a @BeforeSuite method + fix LimitExpiryFactoryTest.
* TestNG modules run ThreadLeakCheckTest from commons-test.
* JUnit modules check for thread leaks in JUnitTestListener
  and/or TestResourceTrackingListener.
* JUnitTestListener.testRunFinished failures still build, so tests that
  may leak threads should use TestResourceTrackingListener.


> Testsuite leaks threads
> -----------------------
>
>                 Key: ISPN-9863
>                 URL: https://issues.jboss.org/browse/ISPN-9863
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Test Suite - Server
>    Affects Versions: 10.0.0.Alpha2, 9.4.5.Final
>            Reporter: Dan Berindei
>            Assignee: Dan Berindei
>            Priority: Major
>              Labels: testsuite_stability
>             Fix For: 10.0.0.Beta3
>
>
> Some hotrod-client tests do not stop their {{RemoteCacheManager}} instances. This was fine before ISPN-8619, but the Netty-based client starts event loop threads and we need to stop them.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)