[infinispan-issues] [JBoss JIRA] (ISPN-10070) DefaultCacheManager should stop components after start failure

[Dan Berindei (Jira)]

     [ https://issues.jboss.org/browse/ISPN-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Berindei updated ISPN-10070:
--------------------------------
              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/infinispan/infinispan/pull/6807


> DefaultCacheManager should stop components after start failure
> --------------------------------------------------------------
>
>                 Key: ISPN-10070
>                 URL: https://issues.jboss.org/browse/ISPN-10070
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 10.0.0.Beta2, 9.4.10.Final
>            Reporter: Dan Berindei
>            Assignee: Dan Berindei
>            Priority: Major
>             Fix For: 10.0.0.Beta4, 9.4.12.Final
>
>
> Currently it is impossible to release all the resources allocated during startup if the {{DefaultCacheManager}} instance was created with {{start=true}}. The user has to do something like this:
> {code:java}
> DefaultCacheManager manager = new DefaultCacheManager(..., false);
> try {
>    manager.start();
> } catch (Throwable t) {
>    manager.stop();
>    throw t;
> }
> {code}
> Both the constructor and the public {{start()}} method should clean up the started components after a startup failure, so that the user doesn't have to call {{stop()}} explicitly.
> Our tests do not currently call {{stop()}} explicitly, so they leak threads and sockets when a manager fails to start (e.g. because something went wrong with the {{CONFIG}} cache).



--
This message was sent by Atlassian Jira
(v7.12.1#712002)