[infinispan-issues] [JBoss JIRA] (ISPN-8241) Refactor RocksDB clearThreshold

[Diego Lovison (Jira)]

    [ https://issues.jboss.org/browse/ISPN-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808540#comment-13808540 ] 

Diego Lovison edited comment on ISPN-8241 at 11/5/19 3:03 PM:
--------------------------------------------------------------

[~william.burns] [~ryanemerson] could we do the following?
Create a random sub-path for dataLocation and expirationLocation when starting the server.
Once the server is started, call java.nio.file.Files::delete and log what were the files that we were not able to remove.
In this case, the sysAdmin can have the system up and running faster and deal with unused files later.


was (Author: dlovison):
[~william.burns] [~ryanemerson] could we do the following?
Create a random sub-path for dataLocation and expirationLocation when starting the server.
Once the server is started, call java.nio.file.Files::delete and log what were the files that we were not able to remove.
In this case, the sysAdmin call have the system up and running faster and deal with unused files later.

> Refactor RocksDB clearThreshold
> -------------------------------
>
>                 Key: ISPN-8241
>                 URL: https://issues.jboss.org/browse/ISPN-8241
>             Project: Infinispan
>          Issue Type: Sub-task
>          Components: Loaders and Stores
>    Affects Versions: 9.1.0.Final
>            Reporter: Ryan Emerson
>            Assignee: Diego Lovison
>            Priority: Major
>             Fix For: 10.1.0.Final
>
>
> Currently the RocksDB store utilises a "clearThreshold" to try to delete entries individually before deleting and re-initiating the database. We should deprecate this threshold and always delete/reinit the database. 
> Currently when deleting the database, we utilise Util.recursiveFileRemove which does not confirm that the file has actually been deleted. Instead, we should provide a nio based implementation instead, similar to the one stated [here|https://stackoverflow.com/questions/779519/delete-directories-recursively-in-java/27917071#27917071]. This has the advantage that an IOException is thrown by java.nio.file.Files::delete



--
This message was sent by Atlassian Jira
(v7.13.8#713008)