[infinispan-issues] [JBoss JIRA] (ISPN-11266) Split CacheTopologyControlCommand into individual commands

Ryan Emerson (Jira) issues at jboss.org
Mon Feb 3 06:39:18 EST 2020


Ryan Emerson created ISPN-11266:
-----------------------------------

             Summary: Split CacheTopologyControlCommand into individual commands
                 Key: ISPN-11266
                 URL: https://issues.redhat.com/browse/ISPN-11266
             Project: Infinispan
          Issue Type: Enhancement
          Components: Core
    Affects Versions: 10.1.1.Final
            Reporter: Ryan Emerson
            Assignee: Ryan Emerson
             Fix For: 11.0.0.Alpha1


Currently the {{CacheTopologyControlCommand}} uses a Type field and a switch statement to differentiate between various topology actions. This worked well for the old Externalizer approach, however it does not fit well with protobuf messages. Instead,  the CacheTopologyControlCommand should be split into individual commands, e.g. a TopologyJoinCommand etc.

This enables the logic of the command types to be separated, making it easier to maintain backwards compatibility in the long term.  Each command will use a ProtoStream TypeId in the range of 1000 -> 3999, so the cost of two bytes is the same as the existing class ID plus enum Type that we require with the single CacheTopologyControlCommand.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)


More information about the infinispan-issues mailing list