[infinispan-issues] [JBoss JIRA] (ISPN-8241) Refactor RocksDB clearThreshold

[Dan Berindei (Jira)]

    [ https://issues.redhat.com/browse/ISPN-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228153#comment-14228153 ] 

Dan Berindei commented on ISPN-8241:
------------------------------------

IMO we should always use {{RocksDB#deleteRange(org.rocksdb.ColumnFamilyHandle, byte[], byte[])}} to clear the store or a segment, and never close+reopen the DB.

> Refactor RocksDB clearThreshold
> -------------------------------
>
>                 Key: ISPN-8241
>                 URL: https://issues.redhat.com/browse/ISPN-8241
>             Project: Infinispan
>          Issue Type: Sub-task
>          Components: Loaders and Stores
>    Affects Versions: 9.1.0.Final
>            Reporter: Ryan Emerson
>            Assignee: Diego Lovison
>            Priority: Major
>
> Currently the RocksDB store utilises a "clearThreshold" to try to delete entries individually before deleting and re-initiating the database. We should deprecate this threshold and always delete/reinit the database. 
> Currently when deleting the database, we utilise Util.recursiveFileRemove which does not confirm that the file has actually been deleted. Instead, we should provide a nio based implementation instead, similar to the one stated [here|https://stackoverflow.com/questions/779519/delete-directories-recursively-in-java/27917071#27917071]. This has the advantage that an IOException is thrown by java.nio.file.Files::delete



--
This message was sent by Atlassian Jira
(v7.13.8#713008)