[infinispan-issues] [JBoss JIRA] (ISPN-11388) Refactor CacheIgnoreManager - AbstractProtocolServer collaboration

[Nistor Adrian (Jira)]

     [ https://issues.redhat.com/browse/ISPN-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nistor Adrian updated ISPN-11388:
---------------------------------
    Git Pull Request: https://github.com/infinispan/infinispan/pull/7963, https://github.com/infinispan/infinispan/pull/7991  (was: https://github.com/infinispan/infinispan/pull/7963)


> Refactor CacheIgnoreManager - AbstractProtocolServer collaboration
> ------------------------------------------------------------------
>
>                 Key: ISPN-11388
>                 URL: https://issues.redhat.com/browse/ISPN-11388
>             Project: Infinispan
>          Issue Type: Enhancement
>          Components: Server
>    Affects Versions: 10.1.0.Final
>            Reporter: Nistor Adrian
>            Assignee: Nistor Adrian
>            Priority: Major
>             Fix For: 10.1.4.Final, 11.0.0.Dev03
>
>
> Given the interactions between  CacheIgnoreManager and AbstractProtocolServer it seems that CacheIgnoreManager should be a global component in the registry of the EmbeddedCacheManager sitting behind the AbstractProtocolServer. It should be looked up from there, or better injected, rather than being received in ProtocolServer.start method. The start method also has an overloaded version that does not take a CacheIgnoreManager to support tests the do not need it. This lack of orthogonality is annoyoing.
> Another aspect to refactor: the startInternal method receives parametters that it assigns to fields. It seems that this should have been done already in the start method. That would get rid of some clunky hacks and some comments/excuses for the said hacks.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)