[infinispan-issues] [JBoss JIRA] (ISPN-10270) DroppedConnectionsTest.testClosedConnection random failures

[Tristan Tarrant (Jira)]

    [ https://issues.redhat.com/browse/ISPN-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995018#comment-13995018 ] 

Tristan Tarrant edited comment on ISPN-10270 at 3/11/20 6:22 AM:
-----------------------------------------------------------------

The test is relying on old (pre-netty) client behaviour, where closing a channel was synchronous. In Netty this is asynchronous, which causes out-of-order issues (which are much more realistic)
Also, the client makes certain assertions based on wrong assumptions:
* RetryOnFailureOperation asserts that a channel must be active when invoking an operation. It does this outside of the try/catch/finally logic. If the channel is closed unexpectedly, the assertion fails but doesn't release the channel.
* ChannelPool claims that protection against concurrent releases is fine, but then has an assertion which fails when decrementing created connections below 0. 



was (Author: nadirx):
The test is relying on old (pre-netty) client behaviour, where closing a channel was synchronous. In Netty this is asynchronous, which causes out-of-order issues.
Also, the client makes certain assertions based on wrong assumptions:
* RetryOnFailureOperation asserts that a channel must be active when invoking an operation. It does this outside of the try/catch/finally logic. If the channel is closed unexpectedly, the assertion fails but doesn't release the channel.
* ChannelPool claims that protection against concurrent releases is fine, but then has an assertion which fails when decrementing created connections below 0. 


> DroppedConnectionsTest.testClosedConnection random failures
> -----------------------------------------------------------
>
>                 Key: ISPN-10270
>                 URL: https://issues.redhat.com/browse/ISPN-10270
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 10.0.0.Beta3
>            Reporter: Dan Berindei
>            Assignee: Tristan Tarrant
>            Priority: Major
>              Labels: testsuite_stability
>         Attachments: ISPN-10137_Injection_without_reflection_20190605-1157_DroppedConnectionsTest-infinispan-client-hotrod.log.gz
>
>
> {noformat}
> 12:03:26,084 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.client.hotrod.DroppedConnectionsTest.testClosedConnection
> java.lang.AssertionError: expected:<1> but was:<0>
> 	at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.14.3.jar:?]
> 	at org.testng.AssertJUnit.failNotEquals(AssertJUnit.java:364) ~[testng-6.14.3.jar:?]
> 	at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:80) ~[testng-6.14.3.jar:?]
> 	at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:245) ~[testng-6.14.3.jar:?]
> 	at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) ~[testng-6.14.3.jar:?]
> 	at org.infinispan.client.hotrod.DroppedConnectionsTest.testClosedConnection(DroppedConnectionsTest.java:78) ~[test-classes/:?]
> {noformat}
> Full trace log attached



--
This message was sent by Atlassian Jira
(v7.13.8#713008)