[infinispan-issues] [JBoss JIRA] (ISPN-11853) Error and Log handling in REST

[Will Burns (Jira)]

    [ https://issues.redhat.com/browse/ISPN-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107258#comment-14107258 ] 

Will Burns commented on ISPN-11853:
-----------------------------------

I am not 100% on the safety, however, I would be very surprised that there isn't some sort of happens before occurring between there. I believe the BlockingQueue put and take would satisfy this, the more I think about it.

https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/package-summary.html#MemoryVisibility

"Actions in a thread prior to placing an object into any concurrent collection happen-before actions subsequent to the access or removal of that element from the collection in another thread."

> Error and Log handling in REST
> ------------------------------
>
>                 Key: ISPN-11853
>                 URL: https://issues.redhat.com/browse/ISPN-11853
>             Project: Infinispan
>          Issue Type: Enhancement
>          Components: REST
>    Affects Versions: 10.1.8.Final
>            Reporter: Katia Aresti
>            Assignee: Gustavo Fernandes
>            Priority: Major
>              Labels: rest
>
> The consistency of the errors handling in the REST endpoint is not even in all the resources, and the completion stage should deal with exceptions raised instead of throwing them directly from the method
> Logs are missing in the REST endpoints, specially trace logs, which makes debugging in production hard
> Finally the NettyRestResponse.Builder apparently is not thread safe, so would be better to make it thread safe



--
This message was sent by Atlassian Jira
(v7.13.8#713008)