[jboss-as7-dev] write-attribute handling [WAS] Who is porting what to detyped?

Kabir Khan kabir.khan at jboss.com
Tue Jan 18 08:10:08 EST 2011


On 18 Jan 2011, at 03:01, Brian Stansberry wrote:

> Kabir,
> 
> Related to the porting work, please have a look at
> 
> https://github.com/bstansberry/jboss-as/tree/attributes
> 
> If it looks good, I'll merge it into detyped2 in the morning.
> 
> That's support for a "write-attribute" operation that can work for any 
> attribute that has a handler registered. The operation takes 2 params:
> 
> name -- the name of the attribute
> value -- the new value
> 
> Resource descriptions will now include a new field for attributes called 
> "access-type". It will have one of 3 values -- read-only, read-write, 
> write-only. Those are generated by the registry; they don't need to be 
> added by the DescriptorProvider.

I have added some tests and a first stab at a validating write operation handler at https://github.com/kabir/jboss-as/commits/attributes.

> 
> If it looks good, use of this mechanism should be the standard way to 
> handle the simple "setFoo" type operations. People would write an 
> OperationHandler to handle the operation, and call 
> ModelNodeRegistration.register(ReadWrite|WriteOnly)Attribute("foo", 
> handler).
One thing which I initially found a bit strange was that attributes with no AttributeAccess were not recognized, but thinking about it a bit I think it makes sense for the user to expicitly have to grant access to the attributes, rather than accidentally getting a default access (whatever that might be).
> 
> I'm sure we can write one or two abstract handlers (with an abstract 
> method to validate the value) plus probably a few concrete ones for some 
> basic common use cases (e.g. accept any non-null String value).
> 
> OT: I noticed the global operations all have "request-properties" as 
> part of the operation structure. That level should only be part of the 
> operation's description, not part of the operation itself.
Fixed in my attributes branch
> 
> On 1/17/11 3:54 PM, Emanuel Muckenhuber wrote:
>> I started with a couple of subsystem last week:
>> 
>> arquillian
>> deployment-scanner
>> ee
>> jmx
>> managed beans
>> messaging
>> naming
>> remoting
>> sar
>> transactions
>> web
>> 
>> Where i'm missing some xml marshalling bits and quite a few things in
>> the messaging module. So i guess the remaining modules are: logging,
>> osgi, maybe security and threads. I think Stefano wanted to get started
>> on the jca integration.
>> 
>> On 01/17/2011 08:43 PM, Kabir Khan wrote:
>>> Just to make sure I don't overlap with somebody else, I am planning to start porting the JMX subsystem to detyped tomorrow. If anybody is already working on this, please let me know ASAP :-)
>>> 
>>> It would be good if people reply to this thread with what subsystems they are working on porting so everybody has an overview.
>>> _______________________________________________
>>> jboss-as7-dev mailing list
>>> jboss-as7-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>> _______________________________________________
>> jboss-as7-dev mailing list
>> jboss-as7-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
> 
> 
> -- 
> Brian Stansberry
> Principal Software Engineer
> JBoss by Red Hat
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev





More information about the jboss-as7-dev mailing list